|From:||Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>|
|To:||Anthony Bykov <a(dot)bykov(at)postgrespro(dot)ru>|
|Subject:||Re: Transform for pl/perl|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
A few very minor comments while quickly paging through:
1. non-ASCII tests are going to cause problems in one platform or
another. Please don't include that one.
2. error messages
a) please use ereport() not elog()
b) conform to style guidelines: errmsg() start with lowercase, others
are complete phrases (start with uppercase, end with period)
"The type you was trying to transform can't be represented in JSONB"
errmsg("could not transform to type \"%s\"", "jsonb"),
errdetail("The type you are trying to transform can't be represented in JSON")
d) same errmsg() for the other error; figure out suitable errdetail.
3. whitespace: don't add newlines to while, DirectFunctionCallN, pnstrdup.
4. the "relocatability" test seems pointless to me.
5. "#undef _" looks bogus. Don't do it.
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
|Next Message||Robert Haas||2017-12-01 18:50:19||Re: Unclear regression test for postgres_fdw|
|Previous Message||Justin Pryzby||2017-12-01 18:34:27||Re: Bitmap scan is undercosted?|