| From: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Anthony Bykov <a(dot)bykov(at)postgrespro(dot)ru> |
| Subject: | Re: Transform for pl/perl |
| Date: | 2017-11-15 08:58:54 |
| Message-ID: | 20171115085854.1377.37552.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
Hello Anthony,
Great patch! Everything is OK and I almost agree with Pavel.
The only thing that I would like to suggest is to add a little more tests for
various corner cases. For instance:
1. Converting in both directions (Perl <-> JSONB) +/- infinity, NaN, MAX_INT,
MIN_INT.
2. Converting in both directions strings that contain non-ASCII (Russian /
Japanese / etc) characters and special characters like \n, \t, \.
3. Make sure that converting Perl objects that are not representable in JSONB
(blessed hashes, file descriptors, regular expressions, ...) doesn't crash
everything and shows a reasonable error message.
The new status of this patch is: Waiting on Author
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2017-11-15 09:01:31 | Re: Schedule for migration to pglister |
| Previous Message | Laurenz Albe | 2017-11-15 08:56:18 | Re: [HACKERS] SQL procedures |