| From: | Robins Tharakan <tharakan(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Fabien Coelho <postgresql(dot)org(at)coelho(dot)net> |
| Subject: | Re: psql - add ability to test whether a variable exists |
| Date: | 2017-09-20 06:38:08 |
| Message-ID: | 20170920063808.1354.88616.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I was able to test the functionality (which seemed to work fine) and fed in my comment to assist anyone else reviewing this patch (and intentionally let it's state as 'Needs Review').
While trying to provide my feedback, on hindsight I should have been more detailed about what I didn't test. Being my first review, I didn't understand that not checking a box meant 'failure'. For e.g. I read the sgml changes, which felt okay but didn't click 'Passed' because my env wasn't setup properly.
I've set this back to 'Needs Review' because clearly needs it.
Apologies for the noise here.
The new status of this patch is: Needs review
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2017-09-20 07:13:05 | Re: psql - add ability to test whether a variable exists |
| Previous Message | Robins Tharakan | 2017-09-20 06:37:46 | Re: psql - add ability to test whether a variable exists |