Re: Re: [PATCH] Fix drop replication slot blocking instead of returning error

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Simone Gotti <simone(dot)gotti(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [PATCH] Fix drop replication slot blocking instead of returning error
Date: 2017-08-29 10:04:33
Message-ID: 20170829100433.h4ta4omkmwpf5r7z@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah Misch wrote:
> On Thu, Aug 24, 2017 at 03:38:20PM +0200, Simone Gotti wrote:
> > I noticed that in postgres 10beta3, calling pg_drop_replication_slot on an
> > active slot will block until it's released instead of returning an error
> > like
> > done in pg 9.6. Since this is a change in the previous behavior and the docs
> > wasn't changed I made a patch to restore the previous behavior.

> > after git commit 9915de6c1cb calls to pg_drop_replication_slot or the
> > replication protocol DROP_REPLICATION_SLOT command will block when a
> > slot is in use instead of returning an error as before (as the doc
> > states).
> >
> > This patch will set nowait to true to restore the previous
> > behavior.

> The above-described topic is currently a PostgreSQL 10 open item.

Looking at it now -- next report tomorrow.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2017-08-29 10:13:02 Re: [PATCH] Fix drop replication slot blocking instead of returning error
Previous Message Masahiko Sawada 2017-08-29 09:23:31 Re: WIP: Separate log file for extension