Re: [PATCH] Fix drop replication slot blocking instead of returning error

From: Noah Misch <noah(at)leadboat(dot)com>
To: alvherre(at)2ndquadrant(dot)com
Cc: Simone Gotti <simone(dot)gotti(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Fix drop replication slot blocking instead of returning error
Date: 2017-08-26 08:07:28
Message-ID: 20170826080728.GC3963697@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 24, 2017 at 03:38:20PM +0200, Simone Gotti wrote:
> I noticed that in postgres 10beta3, calling pg_drop_replication_slot on an
> active slot will block until it's released instead of returning an error
> like
> done in pg 9.6. Since this is a change in the previous behavior and the docs
> wasn't changed I made a patch to restore the previous behavior.
>
> Thanks,
>
> Simone.
>
> --
>
> after git commit 9915de6c1cb calls to pg_drop_replication_slot or the
> replication protocol DROP_REPLICATION_SLOT command will block when a
> slot is in use instead of returning an error as before (as the doc
> states).
>
> This patch will set nowait to true to restore the previous
> behavior.

[Action required within three days. This is a generic notification.]

The above-described topic is currently a PostgreSQL 10 open item. Álvaro,
since you committed the patch believed to have created it, you own this open
item. If some other commit is more relevant or if this does not belong as a
v10 open item, please let us know. Otherwise, please observe the policy on
open item ownership[1] and send a status update within three calendar days of
this message. Include a date for your subsequent status update. Testers may
discover new open items at any time, and I want to plan to get them all fixed
well in advance of shipping v10. Consequently, I will appreciate your efforts
toward speedy resolution. Thanks.

[1] https://www.postgresql.org/message-id/20170404140717.GA2675809%40tornado.leadboat.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2017-08-26 10:49:58 Re: ECPG: WHENEVER statement with DO CONTINUE action
Previous Message Pavel Stehule 2017-08-26 07:44:30 Re: psql - add ability to test whether a variable exists