Re: [postgresql 10 beta3] unrecognized node type: 90

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: [postgresql 10 beta3] unrecognized node type: 90
Date: 2017-08-14 22:29:55
Message-ID: 20170814222955.sowcmnabfdgmlmdn@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2017-08-11 13:26:29 -0700, Andres Freund wrote:
> On 2017-08-11 16:20:51 -0400, Tom Lane wrote:
> > I wrote:
> > > So, apparently somebody wrote ExecReScanGatherMerge, but never bothered
> > > to plug it into ExecReScan. From which we may draw depressing conclusions
> > > about how much it's been tested.
> >
> > While I'm bitching ... the code coverage report at
> >
> > https://coverage.postgresql.org/src/backend/executor/nodeGatherMerge.c.gcov.html
> >
> > also leaves one with less than a warm feeling about the extent of test
> > coverage on this file. heap_compare_slots isn't invoked even once?
>
> I complained about this before at
> http://archives.postgresql.org/message-id/20170401022605.4wag26gtyzhny7ue%40alap3.anarazel.de
> but I just noticed that Rushabh appears to have sent a patch adding
> coverage. Missed that somehow, will apply.

And pushed (to both 10 and master).

- Andres

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-08-14 22:33:57 Re: [COMMITTERS] pgsql: Avoid GatherMerge crash when there are no workers.
Previous Message Peter Eisentraut 2017-08-14 21:39:24 Re: pg_stat_wal_write statistics view

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2017-08-14 22:35:09 Re: BUG #14779: Can't Backup Database
Previous Message myprofmailbox 2017-08-14 21:55:29 BUG #14779: Can't Backup Database