From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: segfault in HEAD when too many nested functions call |
Date: | 2017-07-30 23:47:36 |
Message-ID: | 20170730234736.utxti3avidumq2iy@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2017-07-29 16:14:08 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > [ 0002-Move-ExecProcNode-from-dispatch-to-function-pointer-.patch ]
>
> Here's a reviewed version of this patch.
Thanks! I pushed both now.
> I added dummy ExecProcNodeMtd functions to the various node types that
> lacked them because they expect to be called through MultiExecProcNode
> instead. In the old coding, trying to call ExecProcNode on one of those
> node types would have led to a useful error message; as you had it,
> it'd have dumped core, which is not an improvement.
Ok, makes sense.
> Also, I removed the ExecReScan stanza from ExecProcNodeFirst; that
> should surely be redundant, because we should only get to that function
> through ExecProcNode(). If somehow it's not redundant, please add a
> comment explaining why not.
Makes sense too.
> Some other minor cosmetic changes, mostly comment wordsmithing.
Thanks!
Julien, could you quickly verify that everything's good for you now too?
Regards,
Andres
From | Date | Subject | |
---|---|---|---|
Next Message | Julien Rouhaud | 2017-07-31 00:09:34 | Re: segfault in HEAD when too many nested functions call |
Previous Message | Shay Rojansky | 2017-07-30 23:24:11 | Re: PostgreSQL not setting OpenSSL session id context? |