From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgrowlocks relkind check |
Date: | 2017-04-11 13:17:06 |
Message-ID: | 20170411131706.GR9812@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Amit,
* Amit Langote (Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp) wrote:
> The following commit added relkind checks to certain contrib modules so
> that a more user-friendly error is produced if the wrong kind of relation
> is passed to its functions:
>
> commit c08d82f38ebf763b79bd43ae34b7310ee47aaacd
> Author: Stephen Frost <sfrost(at)snowman(dot)net>
> Date: Thu Mar 9 16:34:25 2017 -0500
>
> Add relkind checks to certain contrib modules
>
> But it missed pgrowlocks, so the following happens:
>
> create extension pgrowlocks;
> create view one as select 1;
> select pgrowlocks('one');
> -- ERROR: could not open file "base/68730/68748": No such file or directory
>
> With the attached patch:
>
> select pgrowlocks('one');
> ERROR: "one" is not a table, index, materialized view, sequence, or TOAST
> table
Good point.
Thanks, I'll see about committing this shortly.
Stephen
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2017-04-11 13:18:06 | Re: Some thoughts about SCRAM implementation |
Previous Message | Magnus Hagander | 2017-04-11 13:14:23 | Re: src/interfaces/libpq shipping nmake-related Makefiles |