| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Mike Palmiotto <mike(dot)palmiotto(at)crunchydata(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: partitioned tables and contrib/sepgsql |
| Date: | 2017-04-05 14:53:54 |
| Message-ID: | 20170405145354.22qnvqgywjnowkw2@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017-04-05 10:48:27 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2017-03-31 20:23:39 -0400, Robert Haas wrote:
> >> 0001 has the problem that we have a firm rule against putting any
> >> #includes whatsoever before "postgres.h". This stdbool issue has come
> >> up before, though, and I fear we're going to need to do something
> >> about it.
>
> > I think in this case it makes sense to deviate from that rule,
> > temporarily and locally.
>
> I'd really rather not. It might be safe here, because this code
> only works on Linux anyway, but it's still a dangerous precedent.
Well, what's the alternative for v10? There's already precedent btw.,
cf plperl.h undefining bool.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-04-05 15:01:34 | Re: Rewriting the test of pg_upgrade as a TAP test |
| Previous Message | Andres Freund | 2017-04-05 14:52:00 | Re: partitioned tables and contrib/sepgsql |