Re: make check-world output

From: Noah Misch <noah(at)leadboat(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: make check-world output
Date: 2017-04-03 23:54:16
Message-ID: 20170403235416.GA2650626@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 03, 2017 at 03:03:44PM +0900, Michael Paquier wrote:
> On Sat, Apr 1, 2017 at 4:28 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> > The pg_upgrade test suite originated in an age when "make check-world" was
> > forbidden to depend on Perl; the choice was a shell script or a C program. We
> > do maintain vcregress.pl:upgradecheck(), a Windows-specific Perl port of the
> > suite. Maintaining both versions has been tedious. I'd welcome a
> > high-quality rewrite using src/test/perl facilities.
>
> I need to check in my archives, but I recall having a WIP patch doing that:
> - remove the shell scripts in src/bin/pg_upgrade.
> - remove upgradecheck in vcregress.pl.
> - add a TAP test in src/bin/pg_upgrade to run the upgrade tests.
> So you are interested by that?

No, not really. A WIP patch is the easy part. The bulk of the work is giving
it all the coverage, debuggability, and robustness of the current harness.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-04-03 23:57:33 Re: PATCH: Batch/pipelining support for libpq
Previous Message David Rowley 2017-04-03 23:52:30 Re: Making clausesel.c Smarter