| From: | Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | michael(dot)paquier(at)gmail(dot)com |
| Cc: | ishii(at)sraoss(dot)co(dot)jp, nag1010(at)gmail(dot)com, horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp, jdnelson(at)dyn(dot)com, pgsql-hackers(at)postgresql(dot)org, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: [BUGS] Bug in Physical Replication Slots (at least 9.5)? |
| Date: | 2017-03-30 00:51:47 |
| Message-ID: | 20170330.095147.1660425449608313162.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
> On Thu, Mar 30, 2017 at 9:12 AM, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:
>> Committers will not apply patches which has trailing whitespace
>> issues. So the patch submitter needs to fix them anyway.
>
> I cannot comment on that point (committers are free to pick up things
> the way they want), but just using git commands to apply a patch
> should not be an obstacle for a review if a patch can be easily
> applied as long as they roughly respect GNU's diff format.
My point is, the coding standard. Having trainling whitespace is
against our coding standard and committers should not accept such a
code, I believe.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2017-03-30 04:51:56 | Re: [HACKERS] Bug in Physical Replication Slots (at least 9.5)? |
| Previous Message | Michael Paquier | 2017-03-30 00:41:30 | Re: [HACKERS] Bug in Physical Replication Slots (at least 9.5)? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haribabu Kommi | 2017-03-30 01:00:02 | Re: Refactor handling of database attributes between pg_dump and pg_dumpall |
| Previous Message | Michael Paquier | 2017-03-30 00:41:30 | Re: [HACKERS] Bug in Physical Replication Slots (at least 9.5)? |