Skip site navigation (1) Skip section navigation (2)

Re: Radix tree for character conversion

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: michael(dot)paquier(at)gmail(dot)com
Cc: hlinnaka(at)iki(dot)fi, daniel(at)yesql(dot)se, peter(dot)eisentraut(at)2ndquadrant(dot)com, robertmhaas(at)gmail(dot)com, tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, ishii(at)sraoss(dot)co(dot)jp, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Radix tree for character conversion
Date: 2017-03-06 08:16:09
Message-ID: 20170306.171609.204324917.horiguchi.kyotaro@lab.ntt.co.jp (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-hackers
Hello,

At Fri, 3 Mar 2017 12:53:04 +0900, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote in <CAB7nPqSQaLozFNg+5Tf9s1TZs2pcE-GHhnMG31qnsusV9vMUOw(at)mail(dot)gmail(dot)com>
> On Thu, Mar 2, 2017 at 2:20 PM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> > 5) Just remove plain map files and all related code. Addition to
> >    that, Makefile stores hash digest of authority files in
> >    Unicode/authoriy_hashes.txt or something that is managed by
> >    git.
> 
> That may be an idea to check for differences across upstream versions.
> But that sounds like a separate discussion to me.

Fine with me either.

> > This digest may differ among platforms (typically from cr/nl
> > difference) but we can assume *nix for the usage.
> >
> > I will send the next version after this discussion is settled.
> 
> Sure. There is not much point to move on without Heikki's opinion at
> least, or anybody else like Ishii-san or Tom who are familiar with
> this code. I would think that Heikki would be the committer to pick up
> this change though.

So, this is the latest version of this patch in the shape of the
option 1.


| need some extra opinions is what to do with the old maps:
| 1) Just remove them, replacing the old maps by the new radix tree maps.
| 2) Keep them around in the backend code, even if they are useless.
| 3) Use a GUC to be able to switch from one to the other, giving a
| fallback method in case of emergency.
| 4) Use an extension module to store the old maps with as well the
| previous build code, so as sanity checks can still be performed on the
| new maps.


regards,

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment: 0001-Use-radix-tree-for-character-conversion_20170306.patch.gz
Description: application/octet-stream (16.4 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Michael PaquierDate: 2017-03-06 08:22:11
Subject: Re: Partitioned tables and relfilenode
Previous:From: Kyotaro HORIGUCHIDate: 2017-03-06 08:07:55
Subject: Re: [BUG FIX] Removing NamedLWLockTrancheArray

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group