Re: Radix tree for character conversion

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, michael(dot)paquier(at)gmail(dot)com
Cc: daniel(at)yesql(dot)se, peter(dot)eisentraut(at)2ndquadrant(dot)com, robertmhaas(at)gmail(dot)com, tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, ishii(at)sraoss(dot)co(dot)jp, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Radix tree for character conversion
Date: 2017-03-13 18:48:07
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 03/06/2017 10:16 AM, Kyotaro HORIGUCHI wrote:
> At Fri, 3 Mar 2017 12:53:04 +0900, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote in <CAB7nPqSQaLozFNg+5Tf9s1TZs2pcE-GHhnMG31qnsusV9vMUOw(at)mail(dot)gmail(dot)com>
>> On Thu, Mar 2, 2017 at 2:20 PM, Kyotaro HORIGUCHI
>> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>> 5) Just remove plain map files and all related code. Addition to
>>> that, Makefile stores hash digest of authority files in
>>> Unicode/authoriy_hashes.txt or something that is managed by
>>> git.
>> That may be an idea to check for differences across upstream versions.
>> But that sounds like a separate discussion to me.
> Fine with me either.

I did some more kibitzing here and there, and committed. Thanks everyone!

I agree the new maps should just replace the old maps altogether, so
committed that way. I also moved the combined map files to the same .map
files as the main radix trees. Seems more clear that way to me.

I changed the to/from_unicode properties back to a single direction
property, with Perl constants BOTH, TO_UNICODE and FROM_UNICODE, per
your alternative suggestion upthread. Seems more clear to me.

It would be nice to run the map_checker tool one more time, though, to
verify that the mappings match those from PostgreSQL 9.6. Just to be
sure, and after that the map checker can go to the dustbin.

- Heikki

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2017-03-13 18:48:47 Re: PATCH: Configurable file mode mask
Previous Message Tomas Vondra 2017-03-13 18:35:55 Re: PATCH: pageinspect / add page_checksum and bt_page_items(bytea)