Re: A typo in mcxt.c

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: andres(at)anarazel(dot)de, Jim(dot)Nasby(at)BlueTreble(dot)com, thomas(dot)munro(at)enterprisedb(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: A typo in mcxt.c
Date: 2017-02-27 04:46:57
Message-ID: 20170227.134657.36493571.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I'm happy to know such a thing. mcxt.c is very stable part of the
code so those who don't know such things like me rarely comes.

At Thu, 23 Feb 2017 22:59:51 -0500, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in <31880(dot)1487908791(at)sss(dot)pgh(dot)pa(dot)us>
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2017-02-23 14:26:07 -0600, Jim Nasby wrote:
> >> On 2/23/17 6:38 AM, Thomas Munro wrote:
> >>> That is an archaic way of contracting the same words differently:
>
> >> Given the number of non-native English speakers we have, it's probably worth
> >> changing it...
>
> > I'm a non-native speaker and I actually like discovering new language
> > "features" every now and then. I think as long as it's not inhibiting
> > understanding to much - which doesn't seem to be the case here - it's
> > fine to keep things like this.
>
> While I don't recall it specifically, git blame says that comment is mine.
> I'm pretty sure it's not a typo, but that the allusion to Hamlet was
> intentional. I think it's good to have a bit of levity and external
> references in our comments; cuts down on the boredom of reading totally
> dry code.
>
> (But see commit d2783bee3 for one hazard of this sort of thing.)
>
> regards, tom lane

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2017-02-27 04:57:25 Re: Proposal : Parallel Merge Join
Previous Message Ashutosh Bapat 2017-02-27 04:35:56 Re: dropping partitioned tables without CASCADE