Re: [COMMITTERS] pgsql: test_pg_dump TAP test whitespace cleanup

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: test_pg_dump TAP test whitespace cleanup
Date: 2017-01-30 20:20:07
Message-ID: 20170130202007.bwyuq2ycmrrtmsh4@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers pgsql-hackers

Stephen Frost wrote:

> Uh, after finding our perltidyrc and running with that, I have to ask,
> why are we setting vertical-tightness to 2 (never break before a closing
> token)? The default of 0 (always break) end up being a lot nicer when
> working on lists. Stacking isolated opening/closing tokens does make
> sense, to me, at least. Then again, I guess those might screw up other
> bits of code. :/

I think it's mostly a matter of personal preference among the (small
group of) people who first set up the perltidy args -- see the thread
around here:
https://www.postgresql.org/message-id/20120616024516.GC26006@momjian.us

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2017-01-30 20:37:14 Re: multivariate statistics (v19)
Previous Message Pavel Stehule 2017-01-30 20:18:53 Re: patch: function xmltable

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-01-30 21:37:36 pgsql: Make psql reject attempts to set special variables to invalid va
Previous Message Stephen Frost 2017-01-30 20:08:29 Re: [COMMITTERS] pgsql: test_pg_dump TAP test whitespace cleanup