Re: Patch: Implement failover on libpq connect level.

From: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
To: Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Patch: Implement failover on libpq connect level.
Date: 2016-09-07 14:32:11
Message-ID: 20160907143211.GC20001@e733
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc

> > 8) get_next_element procedure implementation is way too smart (read
> > "complicated"). You could probably just store current list length and
> > generate a random number between 0 and length-1.
>
> No, algorithm here is more complicated. It must ensure that there would
> not be second attempt to connect to host, for which unsuccessful
> connection attempt was done. So, there is list rearrangement.
>
> Algorithm for pick random list element by single pass is quite trivial.

Great! In this case I would be _trivial_ for you to write a comment that
describes how this procedure works, what makes you think that it gives a
good distribution in all possible cases (e.g. if there is more than
0x10000 elements in a list - why not), etc. Right? :)

--
Best regards,
Aleksander Alekseev

In response to

Browse pgsql-jdbc by date

  From Date Subject
Next Message Victor Wagner 2016-09-08 11:24:20 Re: Patch: Implement failover on libpq connect level.
Previous Message Victor Wagner 2016-09-07 13:56:34 Re: Patch: Implement failover on libpq connect level.

Browse pgsql-hackers by date

  From Date Subject
Next Message Yury Zhuravlev 2016-09-07 14:34:12 Re: Suggestions for first contribution?
Previous Message Aleksander Alekseev 2016-09-07 14:14:44 Re: Suggestions for first contribution?