Re: Obsolete TODO item "-Wcast-align" ?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Christian Convey <christian(dot)convey(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Obsolete TODO item "-Wcast-align" ?
Date: 2016-09-05 17:00:48
Message-ID: 20160905170048.GA13538@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Sep 4, 2016 at 06:10:23PM -0400, Christian Convey wrote:
> On Sun, Sep 4, 2016 at 5:56 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Christian Convey <christian(dot)convey(at)gmail(dot)com> writes:
> >> I chose this item from the TODO page: "[E] Remove warnings created by
> >> -Wcast-align". It didn't have a check-mark after the "[E]", which I
> >> took to mean it's an outstanding issue.
> >> However, I'm starting to wonder if it's already been fixed:
> >
> > No, but you only see it on some platforms/compilers. On my OS X laptop
> > (clang-based not gcc-based compiler), turning that on generates just a
> > hair short of 13000 warnings :-(
> >
> > I think that TODO item is indeed obsolete, but more in the direction
> > of "we're never gonna do that". There are too many places where we
> > do need to cast up from generic pointer to specific structure pointer,
> > and there doesn't seem to be any practical way to tell a compiler which
> > instances are useful to warn about.
>
> Thanks for the response. I'm unclear about how the TODO list is
> curated. Is there someone whose attention I should direct to this
> thread?

Someone has removed the item. It is a wiki so anyone can add/remove
things.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2016-09-05 17:10:07 Re: Minor fix to comments
Previous Message Heikki Linnakangas 2016-09-05 16:38:33 Re: Supporting SJIS as a database encoding