Re: Remove superuser() checks from pgstattuple

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove superuser() checks from pgstattuple
Date: 2016-09-04 23:36:00
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> [ warning, thread hijack ahead ]


> Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > * Peter Eisentraut (peter(dot)eisentraut(at)2ndquadrant(dot)com) wrote:
> >> I think this is a good change to pursue, and we'll likely want to do
> >> more similar changes in contrib. But I'm worried that what is logically
> >> a 10-line change will end up a 20 KiB patch every time.
> > We also created a new version to add the PARALLEL SAFE markings to the
> > functions. In general, I believe it's better to use a new version when
> > we're making these kinds of changes.
> It is becoming clear that the current extension update mechanism is kind
> of brute-force for this sort of change. I have no ideas offhand about a
> better way to do it, but like Peter, I was dismayed by the amount of pure
> overhead involved in the PARALLEL SAFE updates.

To make the patches smaller, it seems that we'd need a way to avoid the
removal and re-addition of the entire install script and a way to avoid
having to add a new upgrade script.

Perhaps if the versioned install script was actually a non-versioned
install script in the source tree, and the Makefile simply installed it
into the correct place, then we could eliminate that part. (All very
hand-wavy, I've not looked at what it'd take to do.)

I don't have any great answers for the upgrade script off-hand. We
could come up with a way for one file to handle multiple upgrade
options, but that doesn't really make the patch any smaller.

> It's not only development overhead, either: users have to remember to
> run around and issue ALTER EXTENSION UPDATE for every extension they
> have, in every database they have it installed in. Anyone want to
> lay a side bet on how many users will actually do that? Given that
> the release notes don't currently suggest doing so, I'd be willing
> to put money on "none at all" :-(

I agree, that's also an issue.

> I wonder whether pg_upgrade ought to be changed to attempt upgrading
> every extension after it's completed the basic migration. Or at
> least offer a script containing all the needed commands.

I like the idea of having an option and documentation to go along with
it. Hopefully that will help administrators at least realize that it's
something they'll want to look at doing.

> Anyway, it's not this particular patch's job to do better, but we
> oughta think about better ways to do it.




In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2016-09-05 00:12:22 Re: OpenSSL 1.1 breaks configure and more
Previous Message Marko Tiikkaja 2016-09-04 23:15:29 Re: Change error code for hstore syntax error