From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | vitus(at)wagner(dot)pp(dot)ru |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: handling unconvertible error messages |
Date: | 2016-08-08 09:11:54 |
Message-ID: | 20160808.181154.252052789.horiguchi.kyotaro@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Mon, 08 Aug 2016 17:18:21 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <20160808(dot)171821(dot)100221089(dot)horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
> Looking at check_client_encoding(), the comment says as following.
>
> | * If we are not within a transaction then PrepareClientEncoding will not
> | * be able to look up the necessary conversion procs. If we are still
> | * starting up, it will return "OK" anyway, and InitializeClientEncoding
> | * will fix things once initialization is far enough along. After
>
> We shold overcome this to realize startup-time check for
> conversion procs.
Somewhat wrong. The core problem is the procedures offered by
PrepareClientEncoding is choosed only by encoding->encoding
basis, not counting character set compatibility. So, currently
this is not detectable before actually doing conversion of a
character stream.
Conversely, providing a means to check character-set
compatibility will naturally fixes this. Check at session-startup
(out-of-transaction check?) is still another problem.
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Victor Wagner | 2016-08-08 09:22:59 | Re: handling unconvertible error messages |
Previous Message | Anastasia Lubennikova | 2016-08-08 08:47:32 | Re: [Patch] Temporary tables that do not bloat pg_catalog (a.k.a fast temp tables) |