| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: Renaming more clearly SHA functions in pgcrypto/ |
| Date: | 2016-07-04 17:09:16 |
| Message-ID: | 20160704170916.GA426299@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier wrote:
> Hi all,
> (folks interested in that in CC)
>
> While looking at some facility in pgcrypto, I have noticed the stanza
> created by 56f4478 to prevent conflicts with OpenSSL, like that:
> +#define SHA256_Init pg_SHA256_Init
> +#define SHA256_Update pg_SHA256_Update
>
> Wouldn't it be better to avoid that, and just rename all those
> functions as pg_shaXX_foo?
Sure.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-07-04 17:16:04 | Re: Re: GiST optimizing memmoves in gistplacetopage for fixed-size updates [PoC] |
| Previous Message | Andrew Borodin | 2016-07-04 17:05:56 | Re: Re: GiST optimizing memmoves in gistplacetopage for fixed-size updates [PoC] |