| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_bsd_indent - improvements around offsetof and sizeof |
| Date: | 2016-05-25 22:19:48 |
| Message-ID: | 20160525221948.67stelvgnk4536av@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016-05-25 18:17:51 -0400, Alvaro Herrera wrote:
> Andres Freund wrote:
> > On 2016-05-25 22:01:53 +0200, Piotr Stefaniak wrote:
> > FWIW, I looked at using clang-format at some point, and it looked like
> > it'd be a number of additional options to make it work for our case
> > without changing the code layout too much. There seemed limited
> > enthusiasm from the authors about accepting relevant options.
>
> FWIW I looked at GNU indent a year ago or so, and there were a few
> things about our style that they simply did not have options for. I
> don't recall the details but my conclusion was that it was a dead end.
Might be worthwhile to look into 'uncrustify'. It's fairly
customizable. A colleague at citus made all citus code be formatted by
it; and while there's some minor details I dislike, it seems to work
ok.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-05-25 22:32:38 | Re: pg_bsd_indent - improvements around offsetof and sizeof |
| Previous Message | Alvaro Herrera | 2016-05-25 22:17:51 | Re: pg_bsd_indent - improvements around offsetof and sizeof |