| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_bsd_indent - improvements around offsetof and sizeof |
| Date: | 2016-05-25 22:32:38 |
| Message-ID: | 14447.1464215558@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Andres Freund wrote:
>> On 2016-05-25 22:01:53 +0200, Piotr Stefaniak wrote:
>>> On 2016-05-25 21:13, Tom Lane wrote:
>>>> I'd love to see a fix for its brain damage around function pointer typedef formatting, too.
>>> Show me a few examples and I'll look into it.
> See src/include/replication/logical.h; the problem there is pretty
> obvious.
More examples are in, eg, src/include/access/amapi.h. It's aligning the
additional lines of a multiline function-pointer typedef to *something*,
but it's not very clear what exactly, and in any case it's indenting them
much too far to have any hope of readability.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-05-25 23:30:00 | Re: [HACKERS] BUG #13473: VACUUM FREEZE mistakenly cancel standby sessions |
| Previous Message | Andres Freund | 2016-05-25 22:19:48 | Re: pg_bsd_indent - improvements around offsetof and sizeof |