Re: Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Christian Ullrich <chris(at)chrullrich(dot)net>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used
Date: 2016-03-29 21:40:32
Message-ID: 20160329214032.GA925857@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

So, it seems that ClientAuthentication() expects to raise ereport(FATAL)
in case of authentication failures. But what's the code path that
causes that to happen if a ereport(ERROR) happens in there? Because all
that code is pretty careful to not do ereport(ERROR) directly and
instead return STATUS_ERROR which makes ClientAuthentication do the
FATAL report. If this doesn't matter, then isn't this whole code overly
complicated for no reason?

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2016-03-29 21:52:05 Re: Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used
Previous Message Christian Ullrich 2016-03-29 21:24:45 Re: BUG #13854: SSPI authentication failure: wrong realm name used

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-03-29 21:44:50 standby_schedule
Previous Message Christian Ullrich 2016-03-29 21:24:45 Re: BUG #13854: SSPI authentication failure: wrong realm name used