Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)

From: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)
Date: 2016-03-25 15:36:27
Message-ID: 20160325183627.328f7714@fujitsu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> In short: the error in Aleksander's argument is the assumption that
> shared hashtables have fixed size. That's simply false.

Well this is a bit embarrassing but I have to admit that you are right.
Dynahash code is a bit non-trivial to say the least (let me guess -
there is no point of suggesting a patch that splits it into two or
three separate implementations for each use case, right? :) and I
misunderstood how it actually works. My apologies.

--
Best regards,
Aleksander Alekseev
http://eax.me/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2016-03-25 15:42:04 Re: [PATCH] Phrase search ported to 9.6
Previous Message Tomas Vondra 2016-03-25 15:32:05 Re: multivariate statistics v14