| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel Aggregate |
| Date: | 2016-03-21 03:24:25 |
| Message-ID: | 20160321032425.GA352138@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley wrote:
> On 21 March 2016 at 15:48, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > David Rowley wrote:
> >
> >> I've rewritten the comment to become:
> >>
> >> /*
> >> * Providing that the estimated size of the hashtable does not exceed
> >> * work_mem, we'll generate a HashAgg Path, although if we were unable
> >> * to sort above, then we'd better generate a Path, so that we at least
> >> * have one.
> >> */
> >>
> >> How about that?
> >
> > I think "Providing" should be "Provided".
>
> Both make sense, although I do only see instances of "Provided that"
> in the source.
Interesting. "Providing that" seems awkward to me, and I had only seen
the other wording thus far, but
http://english.stackexchange.com/questions/149459/what-is-the-difference-between-providing-that-and-provided-that
explains that I'm wrong.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2016-03-21 03:29:49 | Re: Patch: fix lock contention for HASHHDR.mutex |
| Previous Message | Alvaro Herrera | 2016-03-21 03:00:23 | Re: pg_hba_lookup function to get all matching pg_hba.conf entries |