Re: pgbench - allow backslash-continuations in custom scripts

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: coelho(at)cri(dot)ensmp(dot)fr
Cc: david(at)pgmasters(dot)net, robertmhaas(at)gmail(dot)com, michael(dot)paquier(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgbench - allow backslash-continuations in custom scripts
Date: 2016-03-16 03:34:25
Message-ID: 20160316.123425.174869151.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 15 Mar 2016 14:55:52 +0100 (CET), Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote in <alpine(dot)DEB(dot)2(dot)10(dot)1603151455170(dot)23831(at)sto>
>
> >> I intend to have a look at it, I had a look at a previous instance,
> >> but
> >> I'm ok if someone wants to proceed.
> >
> > There's not exactly a long line of reviewers at the moment so if you
> > could do a followup review that would be great.
>
> Ok. It is in the queue, not for right know, though.

Thank you.

This patchset needs "make maintainer-clean" before applying
because it adds src/bin/psql/psqlscan.c, which is currently
generated by flex. All of the patches apply but with many offsets
so I rebased them. The two subsidiary diffs are the same to the
previous patch set.

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-Make-SQL-parser-part-of-psqlscan-independent-from-ps.patch text/x-patch 122.8 KB
0002-pgbench-uses-common-frontend-SQL-parser.patch text/x-patch 18.4 KB
0003-Change-the-way-to-hold-command-list.patch text/x-patch 13.8 KB
psqlscanbody.l.diff text/x-patch 27.8 KB
pgbench.c.patient.diff text/x-patch 9.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2016-03-16 04:01:17 Re: IF (NOT) EXISTS in psql-completion
Previous Message Etsuro Fujita 2016-03-16 03:19:43 Re: Missing conversion error handling in postgres_fdw