From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Victor Wagner <vitus(at)wagner(dot)pp(dot)ru> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Patch: Implement failover on libpq connect level. |
Date: | 2016-02-01 22:05:40 |
Message-ID: | 20160201220540.GA99599@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-jdbc |
Victor Wagner wrote:
> On Fri, 22 Jan 2016 16:36:15 -0300
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> > You're editing the expected file for the libpq-regress thingy, but you
> > haven't added any new lines to test the new capability. I think it'd
> > be good to add some there. (I already said this earlier in the
> > thread; is there any reason you ignored it the first time?)
>
> I seriously doubt that this program can be used to test new
> capabilities.
>
> All it does, it calls PQconninfoParse and than examines some fields of
> PGconn structure.
Ah, you're right, I didn't remember that.
> If I add some new uris, than only thing I can test is that comma is
> properly copied from the URI to this field. And may be that some syntax
> errors are properly detected.
Yeah, we should do that.
> So, I think that new functionality need other approach for testing.
> There should be test of real connection to real temporary cluster.
> Probably, based on Perl TAP framework which is actively used in the
> Postgres recently.
Yes, agreed. So please have a look at that one and share your opinion
about it. It'd be useful.
Meanwhile I'm moving the patch to the next commitfest.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2016-02-01 22:18:21 | Re: snapshot too old, configured by time |
Previous Message | Alvaro Herrera | 2016-02-01 22:02:08 | Re: [POC] FETCH limited by bytes. |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Raiskup | 2016-02-02 17:04:07 | Re: Merge pgjdbc-parent-poms project into pgjdbc please |
Previous Message | Pavel Raiskup | 2016-01-26 15:19:25 | Re: Merge pgjdbc-parent-poms project into pgjdbc please |