Re: pg_receivexlog: spurious error message connecting to 9.3

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>,Robert Haas <robertmhaas(at)gmail(dot)com>,Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>,Craig Ringer <craig(at)2ndquadrant(dot)com>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_receivexlog: spurious error message connecting to 9.3
Date: 2016-01-05 20:27:39
Message-ID: 20160105202739.GA317326@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Michael Paquier wrote:
> On Mon, Dec 7, 2015 at 11:37 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> > The latest patch has another problem; pg_receivexlog trying to connect to
> > the PostgreSQL >= 9.4 always reports the following message unexpectedly.
> >
> > could not identify system: got 1 rows and 4 fields, expected 1 rows
> > and 4 or more fields
> >
> > This problem happens because the patch incorrectly treats the case where
> > IDENTIFY_SYSTEM command returns NULL as database name, as an error case.
> >
> > Attached is the updated version of the patch, which fixes the problem.
> > Comments?
>
> The patch looks good. The top comment of RunIdentifySystem is incorrect
> though. It should mention that a database name is returned and not a plugin
> name.

Right. Pushed with that change to 9.5 and master. Thanks!

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-01-05 20:48:16 Re: Building pg_xlogdump reproducibly
Previous Message Tom Lane 2016-01-05 19:44:55 Re: Beginner hacker item: Fix to_reg*() input type