| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_receivexlog: spurious error message connecting to 9.3 |
| Date: | 2015-12-08 07:39:07 |
| Message-ID: | CAB7nPqT14p41dHgmBJP8OmLww6U9ne61dfEZZGDv9j_UPF+e5Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 7, 2015 at 11:37 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> The latest patch has another problem; pg_receivexlog trying to connect to
> the PostgreSQL >= 9.4 always reports the following message unexpectedly.
>
> could not identify system: got 1 rows and 4 fields, expected 1 rows
> and 4 or more fields
>
> This problem happens because the patch incorrectly treats the case where
> IDENTIFY_SYSTEM command returns NULL as database name, as an error case.
>
> Attached is the updated version of the patch, which fixes the problem.
> Comments?
>
The patch looks good. The top comment of RunIdentifySystem is incorrect
though. It should mention that a database name is returned and not a plugin
name.
(not sure what happened with the last message, gmail went crazy for a
second removing the subject).
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-12-08 07:40:11 | Re: |
| Previous Message | Michael Paquier | 2015-12-08 07:37:15 |