| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Petr Korobeinikov <pkorobeinikov(at)gmail(dot)com> |
| Cc: | Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Beginner hacker item: Fix to_reg*() input type |
| Date: | 2016-01-05 19:44:55 |
| Message-ID: | 11476.1452023095@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Petr Korobeinikov <pkorobeinikov(at)gmail(dot)com> writes:
> 2016-01-05 21:04 GMT+03:00 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>> (I did make some small adjustments --- in this usage, PG_GETARG_TEXT_PP
>> is good enough and likely a bit more efficient than PG_GETARG_TEXT_P.)
> Also I forgot to bump catalog version up. My mishit.
No, submitted patches generally should not touch catversion (though it's
not a bad idea to mention the need for a bump in the submission message).
If you put in a catversion change, it's generally just going to cause
merge failures, since patches seldom get applied instantly.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-01-05 20:27:39 | Re: pg_receivexlog: spurious error message connecting to 9.3 |
| Previous Message | Petr Korobeinikov | 2016-01-05 19:03:30 | Re: Beginner hacker item: Fix to_reg*() input type |