From: | Christoph Berg <christoph(dot)berg(at)credativ(dot)de> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Building pg_xlogdump reproducibly |
Date: | 2016-01-05 10:16:37 |
Message-ID: | 20160105101637.GD25750@msg.credativ.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Re: Alvaro Herrera 2016-01-04 <20160104175623(dot)GA170910(at)alvherre(dot)pgsql>
> > https://reproducible.debian.net/dbd/unstable/armhf/postgresql-9.4_9.4.5-2.diffoscope.html
9.5 was already tested as well, I just couldn't find the link
yesterday:
https://reproducible.debian.net/rb-pkg/experimental/armhf/postgresql-9.5.html
Again, the only real difference between the two builds there is in
pg_xlogdump, the remaining differences are about the checksums of the
surrounding containers (.deb files are really ar files containing
tarballs).
> Ugh. I guess this output is helpful enough given that it mentions the
> offending executable; since our Makefiles are simple enough, we
> shouldn't have much trouble finding the problem spot. I do wonder if
> the CMake conversion is going to cause problems.
cmake is writing makefiles, so I wouldn't expect much problems. (But
it could be the case that problems are harder to fix.)
> > > At least transform modules added in 9.5 (hstore_plpython et al) look
> > > like they might similar issues.
>
> Hmm. hstore_plperl uses $(wildcard) but only in the AIX and Win32
> cases, unless I'm misreading.
>
> I don't see any other $(wildcard) used to build executables; it's used
> for tests and flags in many places, but that shouldn't matter.
Nod. Attached is a patch that covers all relevant $(wildcard)
occurrences in Makefiles for devel.
contrib/hstore_plperl/Makefile | 2 !!
contrib/hstore_plpython/Makefile | 4 !!!!
contrib/ltree_plpython/Makefile | 4 !!!!
src/bin/pg_xlogdump/Makefile | 2 !!
4 files changed, 12 modifications(!)
Mit freundlichen Grüßen,
Christoph Berg
--
Senior Berater, Tel.: +49 (0)21 61 / 46 43-187
credativ GmbH, HRB Mönchengladbach 12080, USt-ID-Nummer: DE204566209
Hohenzollernstr. 133, 41061 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
pgp fingerprint: 5C48 FE61 57F4 9179 5970 87C6 4C5A 6BAB 12D2 A7AE
Attachment | Content-Type | Size |
---|---|---|
sort-wildcard.patch | text/x-diff | 3.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Shulgin, Oleksandr | 2016-01-05 10:35:50 | Re: Inconsistent error handling in START_REPLICATION command |
Previous Message | Shulgin, Oleksandr | 2016-01-05 09:39:49 | Inconsistent error handling in START_REPLICATION command |