| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Christoph Berg <christoph(dot)berg(at)credativ(dot)de> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Building pg_xlogdump reproducibly |
| Date: | 2016-01-05 15:03:45 |
| Message-ID: | 16458.1452006225@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Christoph Berg <christoph(dot)berg(at)credativ(dot)de> writes:
> Re: Alvaro Herrera 2016-01-04 <20160104175623(dot)GA170910(at)alvherre(dot)pgsql>
>> I don't see any other $(wildcard) used to build executables; it's used
>> for tests and flags in many places, but that shouldn't matter.
> Nod. Attached is a patch that covers all relevant $(wildcard)
> occurrences in Makefiles for devel.
There was some upthread discussion of trying to centralize this logic
in a macro, but I think this patch is good as-is. A macro wouldn't
really add any readability, nor would it do much to help us remember
to do the right thing in future places that might need this.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2016-01-05 15:28:25 | Re: [PATCH] Refactoring of LWLock tranches |
| Previous Message | Robert Haas | 2016-01-05 14:57:58 | Re: [PATCH] Refactoring of LWLock tranches |