Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension

From: Noah Misch <noah(at)leadboat(dot)com>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Thom Brown <thom(at)linux(dot)com>, ian(at)2ndquadrant(dot)com, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension
Date: 2015-11-21 19:47:21
Message-ID: 20151121194721.GC1514858@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Nov 20, 2015 at 12:11:00PM -0500, David Steele wrote:
> I fixed many of the issues that caused complaints at the end of the 9.5
> cycle, but there are still two remaining items I would want to address
> before resubmitting:
>
> 1) There was concern about audit messages being sent to the clients.
> I'm looking at adding an option to the ereport macro to suppress sending
> messages to the clients. I'll submit that patch soon.

I don't object to audit messages being client-visible; did anyone feel that
was a blocker? I did make a related point, namely, the documentation must not
assert that you can hide messages from clients if you in fact cannot.

> 2) I would like make install-check to work with modules that require
> shared_preload_libraries. My understanding is that Andrew may have already
> fixed this, but if not I'll look into it.

It would be nice to standardize a pattern for that, agreed.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Steele 2015-11-21 20:15:36 Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension
Previous Message Andrew Dunstan 2015-11-21 14:21:56 pgsql: Fix vcregress.pl's bincheck

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2015-11-21 20:15:36 Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension
Previous Message Andrew Dunstan 2015-11-21 17:29:15 latest buildfarm client release