Re: pgsql: Use JsonbIteratorToken consistently in automatic variable declar

From: Noah Misch <noah(at)leadboat(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Use JsonbIteratorToken consistently in automatic variable declar
Date: 2015-10-12 14:17:08
Message-ID: 20151012141708.GB128792@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Oct 12, 2015 at 09:56:30AM -0400, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > Use JsonbIteratorToken consistently in automatic variable declarations.
> > Many functions stored JsonbIteratorToken values in variables of other
> > integer types. Also, standardize order relative to other declarations.
> > Expect compilers to generate the same code before and after this change.
>
> FWIW, I think this sort of thing should get back-patched.

Works for me. Done.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-10-12 22:31:00 pgsql: Fix "pg_ctl start -w" to test child process status directly.
Previous Message Noah Misch 2015-10-12 14:14:37 pgsql: Use JsonbIteratorToken consistently in automatic variable declar