From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
Cc: | Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: BRIN INDEX value |
Date: | 2015-09-04 16:56:42 |
Message-ID: | 20150904165642.GK2912@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tatsuo Ishii wrote:
> > On 9/4/2015 2:04 PM, Tatsuo Ishii wrote:
> >>> One thing I imagine we could do is to change the signature of
> >>> summrize_range() to also include heapNumBlks which its (only) caller
> >>> brinsummarize() already computes. It will look like:
> >>>
> >>> static void summarize_range(IndexInfo *indexInfo, BrinBuildState *state,
> >>> Relation heapRel,
> >>> BlockNumber heapBlk,
> >>> BlockNumber heapNumBlks);
> >>>
> >>> I'd think changing summarize_range()'s signature would be relatively
> >>> easier/safer.
> >>
> >> Yeah, sounds good.
> >
> > Here's a patch to do that.
>
> Thanks. It looks good to me (and passed all the regression tests in
> master branch). I will commit your patch if there's no objection.
Yeah, thanks, please go ahead.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Rugal Bernstein | 2015-09-04 17:01:12 | Re: A better translation version of Chinese for psql/po/zh_CN.po file |
Previous Message | Andres Freund | 2015-09-04 16:37:25 | Re: Allow a per-tablespace effective_io_concurrency setting |