| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: creating extension including dependencies |
| Date: | 2015-09-02 15:31:20 |
| Message-ID: | 20150902153120.GA6822@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-09-02 17:27:38 +0200, Andres Freund wrote:
> 1) Passing the list of parents through the cascade DefElem strikes me as
> incredibly ugly.
>
> For one the cascade option really should take a true/false type option
> on the C level (so you can do defGetBoolean()), for another passing
> through the list of parents via DefElem->arg seems wrong. You're
> supposed to be able to copy parsenodes and at the very least that's
> broken by the approach.
I think the fix here is to split off the bulk of CreateExtension() into
an internal function that takes additional parameters.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oleg Bartunov | 2015-09-02 15:34:23 | Re: Horizontal scalability/sharding |
| Previous Message | Joshua D. Drake | 2015-09-02 15:28:29 | PSA: Upcoming Linux scheduler changes |