| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: creating extension including dependencies |
| Date: | 2015-09-02 15:27:38 |
| Message-ID: | 20150902152738.GC5286@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I'm looking at committing this patch. I found some nitpick-level things
that I can easily fixup. But I dislike two things:
1) Passing the list of parents through the cascade DefElem strikes me as
incredibly ugly.
For one the cascade option really should take a true/false type option
on the C level (so you can do defGetBoolean()), for another passing
through the list of parents via DefElem->arg seems wrong. You're
supposed to be able to copy parsenodes and at the very least that's
broken by the approach.
2) I don't like the control flow around the schema selection.
It seems to be getting a bit arcane. How about instead moving the
"extension \"%s\" must be installed in schema \"%s\" check into the if
(control->schema != NULL) block and check for d_schema after it? That
should look cleaner.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2015-09-02 15:28:29 | PSA: Upcoming Linux scheduler changes |
| Previous Message | Noah Misch | 2015-09-02 15:12:40 | Re: WIP: About CMake v2 |