Re: [COMMITTERS] pgsql: Further fixes for degenerate outer join clauses.

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: Further fixes for degenerate outer join clauses.
Date: 2015-08-13 14:10:05
Message-ID: 20150813141005.GY3685@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> I'm not entirely sure what to do about this. We could back-patch that
> patch into 9.0 and 9.1, but it's conceivable somebody would squawk about
> planner behavioral changes. The only other idea that seems practical is
> to remove regression test cases that have platform-specific results in
> those branches. Probably that wouldn't result in a real reduction in the
> quality of the test coverage for those branches (we could still execute
> the query, just not EXPLAIN it). But it seems like a pretty ad-hoc
> answer, and the next case might be one that hurts more not to test.
>
> Thoughts?

Have an alternate file for those other cases, rather than remove the
test? The complaint was about one buildfarm member, so hopefully that's
practical and doesn't require a lot of different permutations.

Thanks!

Stephen

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-08-13 14:26:26 Re: [COMMITTERS] pgsql: Further fixes for degenerate outer join clauses.
Previous Message Heikki Linnakangas 2015-08-13 11:38:20 Re: pgsql: Replace our hacked version of ax_pthread.m4 with latest upstream

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-08-13 14:26:26 Re: [COMMITTERS] pgsql: Further fixes for degenerate outer join clauses.
Previous Message David Steele 2015-08-13 14:04:21 Re: Test code is worth the space