Re: [COMMITTERS] pgsql: Close some holes in BRIN page assignment

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Close some holes in BRIN page assignment
Date: 2015-08-13 09:38:37
Message-ID: 20150813093836.GG21836@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2015-08-13 00:24:29 -0300, Alvaro Herrera wrote:
> Andres Freund wrote:
> > On 2015-08-12 16:08:08 -0300, Alvaro Herrera wrote:
> > > Alvaro Herrera wrote:
> > > > Close some holes in BRIN page assignment
> > >
> > > buildfarm evidently didn't like this one :-(
> >
> > clang seems to see a (the?) problem:
>
> Ahh, right. There's an identical problem in the other function
> (brin_doupdate); maybe the conditional there is more complicated than it
> wants to analyze. I was trying randomized memory and wasn't finding
> anything ...
>
> BTW I looked around the buildfarm and couldn't find a single member that
> displayed these warnings :-(

I tripped on clang 3.7 (unreleased) and a fairly extensive set of
warning flags (-Weverything + -Wno-... of the stupid ones)...

FWIW, this very likely would have tripped in valgrind. Just running that
single test will not even be too slow.

Regards,

Andres

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Syed, Rahila 2015-08-13 10:12:04 Re: [PROPOSAL] VACUUM Progress Checker.
Previous Message Taiki Kondo 2015-08-13 09:29:34 [Proposal] Table partition + join pushdown

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Meskes 2015-08-13 11:26:49 pgsql: Fix declaration of isarray variable.
Previous Message Alvaro Herrera 2015-08-13 03:24:29 Re: [COMMITTERS] pgsql: Close some holes in BRIN page assignment