Re: [COMMITTERS] pgsql: Close some holes in BRIN page assignment

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Close some holes in BRIN page assignment
Date: 2015-08-13 03:24:29
Message-ID: 20150813032429.GN3040@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Andres Freund wrote:
> On 2015-08-12 16:08:08 -0300, Alvaro Herrera wrote:
> > Alvaro Herrera wrote:
> > > Close some holes in BRIN page assignment
> >
> > buildfarm evidently didn't like this one :-(
>
> clang seems to see a (the?) problem:

Ahh, right. There's an identical problem in the other function
(brin_doupdate); maybe the conditional there is more complicated than it
wants to analyze. I was trying randomized memory and wasn't finding
anything ...

BTW I looked around the buildfarm and couldn't find a single member that
displayed these warnings :-(

> Looks to me like it's right. That also explains why it's failing on a
> fairly random selection of platforms and compilers...

Yeah ...

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2015-08-13 09:38:37 Re: [COMMITTERS] pgsql: Close some holes in BRIN page assignment
Previous Message Alvaro Herrera 2015-08-13 03:15:09 pgsql: Fix unitialized variables

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Bartunov 2015-08-13 03:28:09 Re: GIN pending list clean up exposure to SQL
Previous Message Robert Haas 2015-08-13 03:00:19 Re: WIP: SCRAM authentication