Re: upgrade failure from 9.5 to head

From: Noah Misch <noah(at)leadboat(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: upgrade failure from 9.5 to head
Date: 2015-08-01 23:13:05
Message-ID: 20150801231305.GA1651515@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 29, 2015 at 04:42:55PM -0400, Andrew Dunstan wrote:
> The next hump is this, in restoring contrib_regression_test_ddl_parse:
>
> pg_restore: creating FUNCTION "public"."text_w_default_in("cstring")"
> pg_restore: [archiver (db)] Error while PROCESSING TOC:
> pg_restore: [archiver (db)] Error from TOC entry 243; 1255 62534
> FUNCTION text_w_default_in("cstring") buildfarm
> pg_restore: [archiver (db)] could not execute query: ERROR: pg_type
> OID value not set when in binary upgrade mode
> Command was: CREATE FUNCTION "text_w_default_in"("cstring")
> RETURNS "text_w_default"
> LANGUAGE "internal" STABLE STRICT
> AS $$texti...
>
> Is this worth bothering about, or should I simply remove the database before
> trying to upgrade?

That's a bug. The test_ddl_deparse suite leaves a shell type, which
pg_upgrade fails to reproduce. Whether to have pg_upgrade support that or
just error out cleanly is another question.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2015-08-01 23:20:58 Re: TAP tests are badly named
Previous Message Andrew Dunstan 2015-08-01 23:13:04 Re: TAP tests are badly named