| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: Make timestamptz_out less slow. |
| Date: | 2015-07-29 02:28:32 |
| Message-ID: | 20150729022832.GA9954@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-07-29 09:37:26 +1200, David Rowley wrote:
> On 29 July 2015 at 03:25, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> > On 2015-07-29 03:10:41 +1200, David Rowley wrote:
> > > Have you thought about what to do when HAVE_INT64_TIMESTAMP is not
> > defined?
> >
> > I don't think it's actually important. The only difference vs float
> > timestamps is that in the latter case we set fsecs to zero BC.
> >
> >
> I was also thinking that the % 10 won't work when fsec_t is double.
>
> typedef double fsec_t
It seems quite possible to move that bit to timestamp2tm and do it
without a dependency on HAVE_INT64_TIMESTAMP. As long as it doesn't slow
down the int timestamp case I'm happy to simplify code in this area.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rajeev rastogi | 2015-07-29 02:50:09 | Re: Autonomous Transaction is back |
| Previous Message | Amit Langote | 2015-07-29 02:26:29 | Typo in comment in ATPrepChangePersistence |