Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Shouldn't CREATE TABLE LIKE copy the relhasoids property?
Date: 2015-04-29 19:48:04
Message-ID: 20150429194804.GK31727@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 28, 2015 at 09:15:49AM -0400, Bruce Momjian wrote:
> > It seems to me that waiting for 9.6 for what's arguably a bug fix is too
> > much. It's not like this is a new feature. Why don't we just make sure
> > it is as correct as possible and get it done for 9.5? It's not even in
> > beta yet, nor feature freeze.
>
> Well, I applied what I thought would work, but did not handle three
> cases:
>
> * checking of hasoids by index specifications
> * queries with multiple LIKE'ed tables
> * matching inheritance behavior
>
> I am unclear if I should be addressing such complex issues at this point
> in the development cycle. I can certainly apply this patch, but I need
> someone else to tell me it is good and should be applied. I am also
> thinking such review time would be better spent on patches submitted
> long before mine.

I have added regression tests to the patch, attached. I have included
Tom's test that doesn't directly use LIKE.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachment Content-Type Size
like.diff text/x-diff 7.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-04-29 19:50:07 Re: why does enum_endpoint call GetTransactionSnapshot()?
Previous Message Szymon Guz 2015-04-29 19:45:47 Re: Help needed for PL/Ruby