| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: Sloppy SSPI error reporting code |
| Date: | 2015-04-02 02:49:01 |
| Message-ID: | 20150402024901.GD29404@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 10, 2015 at 02:53:13PM -0500, Tom Lane wrote:
> While looking at fe-auth.c I noticed quite a few places that weren't
> bothering to make error messages localizable (ie, missing libpq_gettext
> calls), and/or were failing to add a trailing newline as expected in
> libpq error messages. Perhaps these are intentional but I doubt it.
> Most of the instances seemed to be SSPI-related.
>
> I have no intention of fixing these myself, but whoever committed that
> code should take a second look.
I looked through that file and only found two cases; patch attached.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| Attachment | Content-Type | Size |
|---|---|---|
| libpq.diff | text/x-diff | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2015-04-02 03:07:05 | Re: POLA violation with \c service= |
| Previous Message | Michael Paquier | 2015-04-02 02:46:53 | Re: POLA violation with \c service= |