| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: forward vs backward slashes in msvc build code |
| Date: | 2015-03-12 21:20:56 |
| Message-ID: | 20150312212056.GE3291@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> On 3/4/15 11:00 PM, Andrew Dunstan wrote:
> >
> > On 03/04/2015 10:37 PM, Peter Eisentraut wrote:
> >> I can't tell from just looking at the code how chkpass would normally
> >> find crypt. The msvc tools neither parse SHLIB_LINK nor have hardcoded
> >> knowledge. Any idea?
>
> > Which library is it in? There are sections at the top of Mkvcbuild.pm
> > for including various libraries in contrib modules that need them.
>
> This is contrib/chkpass not finding the crypt symbol, which is
> presumably in some library. But I can't see how it would normally find
> it, without my patch.
It seems crypt is provided by libpgport. So chkpass should be mentioned
in @contrib_uselibpgport, but isn't. Maybe the fix is just to add it
there?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-03-12 21:28:47 | Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API) |
| Previous Message | Robert Haas | 2015-03-12 21:09:10 | Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API) |