Re: pg_rewind in contrib

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Satoshi Nagayasu <snaga(at)uptime(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <mpaquier(at)vmware(dot)com>
Subject: Re: pg_rewind in contrib
Date: 2015-03-09 14:59:46
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Heikki Linnakangas wrote:

> Attached is a new patch version, fixing all the little things you listed. I
> believe this is pretty much ready for commit. I'm going to read it through
> myself one more time before committing, but I don't have anything mind now
> that needs fixing anymore.

I do -- it's obvious that you've given some consideration to
translatability, but it's not complete: anything that's using fprintf()
and friends are not marked for translation with _(). There are lots of
things using pg_fatal etc and those are probably fine.

One big thing that's not currently translated is usage(), but there are

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Воронин Дмитрий 2015-03-09 15:16:54 Re: New functions
Previous Message Robert Haas 2015-03-09 14:55:57 Re: One question about security label command