From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: New CF app deployment |
Date: | 2015-03-03 15:58:28 |
Message-ID: | 20150303155828.GD5726@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Feb 22, 2015 at 03:12:12PM -0500, Magnus Hagander wrote:
> > # Attempt to identify the file using magic information
> > mtype = mag.buffer(contents)
> > if mtype.startswith('text/x-diff'):
> > a.ispatch = True
> > else:
> > a.ispatch = False
...
>
> I think the old system where the patch submitter declared, this message
> contains my patch, is the only one that will work.
>
>
>
> Would you suggest removing the automated system completely, or keep it around
> and just make it possible to override it (either by removing the note that
> something is a patch, or by making something that's not listed as a patch
> become marked as such)?
One counter-idea would be to assume every attachment is a patch _unless_
the attachment type matches a pattern that identifies it as not a patch.
However, I agree with Tom that we should go a little longer before
changing it.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-03-03 16:09:29 | Re: autogenerated column names + views are a dump hazard |
Previous Message | Andres Freund | 2015-03-03 15:58:05 | Re: autogenerated column names + views are a dump hazard |