Re: pgbench -f and vacuum

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: fabriziomello(at)gmail(dot)com
Cc: masao(dot)fujii(at)gmail(dot)com, Jim(dot)Nasby(at)bluetreble(dot)com, dgrowleyml(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgbench -f and vacuum
Date: 2014-12-21 23:25:45
Message-ID: 20141222.082545.1668382394710421328.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> - Error to apply to the current master:

Works for me.

$ git apply ~/pgbench-f-noexit-v2.patch
$

Maybe git version difference or the patch file was malformed by mail
client?

> +static void executeStatement2(PGconn *con, const char *sql, const char
> *table);
>
> I think we can use a better name like "executeStatementIfTableExists".

Point taken.

> + if (result == NULL)
> + {
> + PQclear(res);
> + return false;
> + }
> +
> + if (*result == 't')
> + {
> + PQclear(res);
> + return false; /* table does not exist */
> + }
>
> To simplify isn't better this way?
>
> if (result == NULL || *result == 't')
> {
> PQclear(res);
> return false; /* table does not exists */
> }

Thanks for pointing it out.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2014-12-21 23:28:46 Re: pgbench -f and vacuum
Previous Message Fabrízio de Royes Mello 2014-12-21 21:30:35 Re: Proposal "VACUUM SCHEMA"