Re: Review of GetUserId() Usage

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Review of GetUserId() Usage
Date: 2014-11-29 20:00:54
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


* Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> * Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> > Attached is a patch to address the pg_cancel/terminate_backend and the
> > statistics info as discussed previously. It sounds like we're coming to
> And I forgot the attachment, of course. Apologies.

Updated patch attached which also changes the error messages (which
hadn't been updated in the prior versions and really should be).

Barring objections, I plan to move forward with this one and get this
relatively minor change wrapped up. As mentioned in the commit, while
this might be an arguably back-patchable change, the lack of field
complaints and the fact that it changes existing behavior mean it should
go only against master, imv.



Attachment Content-Type Size
getuserid_cleanup.patch text/x-diff 6.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-11-29 20:06:48 Re: [COMMITTERS] pgsql: Revert "Add libpq function PQhostaddr()."
Previous Message Noah Misch 2014-11-29 19:31:25 Re: [COMMITTERS] pgsql: Revert "Add libpq function PQhostaddr()."