Re: [COMMITTERS] pgsql: Revert "Add libpq function PQhostaddr()."

From: Noah Misch <noah(at)leadboat(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: Revert "Add libpq function PQhostaddr()."
Date: 2014-11-29 19:31:25
Message-ID: 20141129193125.GD1249202@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Nov 29, 2014 at 02:09:09PM -0500, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > Revert "Add libpq function PQhostaddr()."
> > This reverts commit 9f80f4835a55a1cbffcda5d23a617917f3286c14. The
> > function returned the raw value of a connection parameter, a task served
> > by PQconninfo(). The next commit will reimplement the psql \conninfo
> > change that way. Back-patch to 9.4, where that commit first appeared.
>
> I confess to not having been paying too much attention to your discussion
> with Fujii over the holiday, but isn't it a bit too late to be making
> client-API-breaking changes in 9.4? I would have been fine with this
> before RC1 went out, but once we do that, the branch should be treated
> as released.

I had considered that, and one could make a reasonable case for living with
the new symbol on that basis. For the release candidate stage to have value,
though, the "treat as released" principle must not be absolute. I regret not
noticing the problem earlier.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2014-11-29 20:06:48 Re: [COMMITTERS] pgsql: Revert "Add libpq function PQhostaddr()."
Previous Message Tom Lane 2014-11-29 19:19:10 Re: [COMMITTERS] pgsql: Revert "Add libpq function PQhostaddr()."

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2014-11-29 20:00:54 Re: Review of GetUserId() Usage
Previous Message Tom Lane 2014-11-29 19:19:10 Re: [COMMITTERS] pgsql: Revert "Add libpq function PQhostaddr()."